feat(dashboard): Colors and button setup #6594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SokratisVidros
approved these changes
Sep 30, 2024
| import { Slot } from "@radix-ui/react-slot"; | ||
| import { cva, type VariantProps } from "class-variance-authority"; | ||
| import { cn } from "@/utils/ui"; | ||
| import * as React from 'react'; |
There was a problem hiding this comment.
@desiprisg I was under the impression that the primitives folder is where we download the ShadUI code.
What's the recommended framework for applying modifications to the ShadUI code? Do it in there or in a different place?
There was a problem hiding this comment.
You can directly edit the primitives and variants as needed. That's the difference between shadcn/ui and conventional ui libraries.
desiprisg
force-pushed
the
nv-4312-design-system-setup
branch
from
1234903
to
5fe8c85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer