Support more types (byte, short, utf16 strings...) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleavr
requested changes
Feb 10, 2017
index.js
Outdated
| @@ -268,6 +274,28 @@ function int() { | |||
| }; | |||
| } | |||
|
|
|||
| function byte() { | |||
There was a problem hiding this comment.
Could we move these up so they match the order at the top? (byte, short, then int)
|
done
… On 10 Feb 2017, at 02:45, Ole André Vadla Ravnås ***@***.***> wrote:
@oleavr requested changes on this pull request.
Awesome! Just one small nit:
In index.js <#4 (review)>:
> @@ -268,6 +274,28 @@ function int() {
};
}
+function byte() {
Could we move these up so they match the order at the top? (byte, short, then int)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#4 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGIjG_eS0dmvg-vehKK00FPlZBogSMeCks5ra8FMgaJpZM4L7G3U>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.