Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GameViewResolutionAttribute using IOuterUnityTestAction #25

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

nowsprinting
Copy link
Owner

@nowsprinting nowsprinting commented Oct 26, 2023

Before:
Implements IApplyToContext interface

After:
Implements IOuterUnityTestAction interface

Benefits:

  • Not require awaiting before test code
  • Support sync test

@github-actions github-actions bot added the enhancement New feature or request label Oct 26, 2023
@github-actions
Copy link

Code Metrics Report

master (b980305) #25 (f0691a2) +/-
Coverage 53.8% 55.5% +1.7%
Code to Test Ratio 1:0.9 1:0.9 +0.0
Test Execution Time 4m37s 4m37s 0s
Details
  |                     | master (b980305) | #25 (f0691a2) |  +/-  |
  |---------------------|------------------|---------------|-------|
+ | Coverage            |            53.8% |         55.5% | +1.7% |
  |   Files             |               17 |            17 |     0 |
  |   Lines             |              448 |           452 |    +4 |
+ |   Covered           |              241 |           251 |   +10 |
+ | Code to Test Ratio  |            1:0.9 |         1:0.9 |  +0.0 |
  |   Code              |              806 |           812 |    +6 |
+ |   Test              |              702 |           709 |    +7 |
  | Test Execution Time |            4m37s |         4m37s |    0s |

Code coverage of files in pull request scope (15.2% → 34.0%)

Files Coverage +/-
Runtime/Attributes/GameViewResolutionAttribute.cs 34.0% +18.8%

Reported by octocov

@nowsprinting nowsprinting merged commit 6b1cff9 into master Oct 26, 2023
9 checks passed
@nowsprinting nowsprinting deleted the feature/refactor_gameviewresolutionattribute branch October 26, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant