Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Refactor GameViewResolutionAttribute using IOuterUnityTestAction" #26

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

nowsprinting
Copy link
Owner

@nowsprinting nowsprinting commented Oct 27, 2023

Revert #25

Because IOuterUnityTestAction can not attach to test class and test assembly.

@github-actions github-actions bot added the bug Something isn't working label Oct 27, 2023
@github-actions
Copy link

Code Metrics Report

master (6b1cff9) #26 (98f8cff) +/-
Coverage 55.5% 53.8% -1.7%
Code to Test Ratio 1:0.9 1:0.9 -0.0
Test Execution Time 5m14s 4m33s -41s
Details
  |                     | master (6b1cff9) | #26 (98f8cff) |  +/-  |
  |---------------------|------------------|---------------|-------|
- | Coverage            |            55.5% |         53.8% | -1.7% |
  |   Files             |               17 |            17 |     0 |
  |   Lines             |              452 |           448 |    -4 |
- |   Covered           |              251 |           241 |   -10 |
- | Code to Test Ratio  |            1:0.9 |         1:0.9 |  -0.0 |
  |   Code              |              812 |           806 |    -6 |
- |   Test              |              709 |           702 |    -7 |
+ | Test Execution Time |            5m14s |         4m33s |  -41s |

Code coverage of files in pull request scope (34.0% → 15.2%)

Files Coverage +/-
Runtime/Attributes/GameViewResolutionAttribute.cs 15.2% -18.8%

Reported by octocov

@nowsprinting nowsprinting merged commit 40ef007 into master Oct 27, 2023
9 checks passed
@nowsprinting nowsprinting deleted the fix/revert_gameviewresolutionattribute branch October 27, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant