Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress double quote in screenshot filename #67

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

nowsprinting
Copy link
Owner

It will be inserted if there is a string parameter in a parameterized test.
It is also suppressed by the Graphics Tests Framework package.

@github-actions github-actions bot added the bug Something isn't working label Apr 7, 2024
Copy link

github-actions bot commented Apr 7, 2024

Code Metrics Report

master (3023fa4) #67 (81dfac1) +/-
Coverage 66.8% 66.8% 0.0%
Code to Test Ratio 1:2.0 1:2.0 0.0
Test Execution Time 3m13s 5m9s +1m56s
Details
  |                     | master (3023fa4) | #67 (81dfac1) |  +/-   |
  |---------------------|------------------|---------------|--------|
  | Coverage            |            66.8% |         66.8% |   0.0% |
  |   Files             |               24 |            24 |      0 |
  |   Lines             |              548 |           548 |      0 |
  |   Covered           |              366 |           366 |      0 |
  | Code to Test Ratio  |            1:2.0 |         1:2.0 |    0.0 |
  |   Code              |              543 |           543 |      0 |
  |   Test              |             1103 |          1103 |      0 |
- | Test Execution Time |            3m13s |          5m9s | +1m56s |

Code coverage of files in pull request scope (100.0% → 100.0%)

Files Coverage +/-
RuntimeInternals/ScreenshotHelper.cs 100.0% 0.0%

Reported by octocov

@nowsprinting nowsprinting merged commit e668229 into master Apr 7, 2024
9 checks passed
@nowsprinting nowsprinting deleted the fix/screenshot_filename branch April 7, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant