client: added parentRequestOptions #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client.go
Outdated
| @@ -141,6 +144,13 @@ func (cl *Client) Do(c context.Context, req *Request) (*Response, error) { | |||
| return resp, nil | |||
| } | |||
|
|
|||
| func WithParentRequestOptions(opts []RequestOption) ClientOption { | |||
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported function WithParentRequestOptions should have comment or be unexported
There was a problem hiding this comment.
I'd probably call the public function WithRequestOptions
There was a problem hiding this comment.
good point. I'll change that.
|
Thanks reviewdog! |
for RequestOption inheritance with NewRequest
josephbergevin
force-pushed
the
request-inherit-client-options
branch
from
cccaf7d
to
915d2d0
Compare
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 38.61% 38.41% -0.21%
==========================================
Files 7 7
Lines 448 453 +5
==========================================
+ Hits 173 174 +1
- Misses 247 251 +4
Partials 28 28
Continue to review full report at Codecov.
|
|
closes issue #25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowing RequestOption inheritance with NewRequest