Skip to content
This repository has been archived by the owner on Dec 2, 2019. It is now read-only.

Commit

Permalink
Remove Node definition, which pollutes global namespace and prevents …
Browse files Browse the repository at this point in the history
…dependent TS projects from building

When a package has Shopify-Prime as a dependency, and has its own node.d.ts definition installed, the two definitions will clash and break the dependent's build because globals aren't scoped to their own packages. There is some work being done by MS at (microsoft/TypeScript#4913) to fix the problem.
  • Loading branch information
nozzlegear committed Jun 4, 2016
1 parent b9c6192 commit d75c8d5
Show file tree
Hide file tree
Showing 9 changed files with 162 additions and 2,411 deletions.
2 changes: 1 addition & 1 deletion index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// https://www.typescriptlang.org/docs/handbook/typings-for-npm-packages.html

import uri = require("jsuri");
import * as crypto from "crypto";
import * as crypto from "crypto";
import * as fetch from "node-fetch";
import {BaseService, ListOptions, FieldOptions} from "./modules/base_service";

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "shopify-prime",
"version": "1.0.5",
"version": "1.0.6",
"description": "Shopify Prime is a NodeJS library built to help developers easily authenticate and make calls against the Shopify API. It was inspired by and borrows heavily from ShopifySharp.",
"main": "dist/index.js",
"scripts": {
Expand Down
2 changes: 2 additions & 0 deletions tests/_utils.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
/// <reference path="./../typings/index.d.ts" />

declare const process: {env: any};

const config: {[prop: string]: string} = process.env;

// Grab secret keys
Expand Down
4 changes: 2 additions & 2 deletions typings.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
"main": "dist/index.d.ts",
"ambient": false,
"dependencies": {
"crypto": "github:nozzlegear/crypto.d.ts#1b1ca92",
"node-fetch": "github:nozzlegear/node-fetch.d.ts#6abf724"
},
"globalDependencies": {
"jsuri": "registry:dt/jsuri#1.3.0+20160317120654",
"node": "registry:env/node#4.0.0+20160507210304"
"jsuri": "registry:dt/jsuri#1.3.0+20160317120654"
},
"devDependencies": {
"chai": "registry:npm/chai#3.5.0+20160415060238"
Expand Down
Loading

0 comments on commit d75c8d5

Please sign in to comment.