Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel fulfilment endpoint missing after upgrade to 2022-07 #833

Closed
thomotron opened this issue Jan 20, 2023 · 3 comments · Fixed by #834
Closed

Cancel fulfilment endpoint missing after upgrade to 2022-07 #833

thomotron opened this issue Jan 20, 2023 · 3 comments · Fixed by #834

Comments

@thomotron
Copy link
Contributor

As part of the upgrade to 2022-07, several deprecated fulfilment endpoints were removed (see af14afb) including CancelAsync. However, there was another cancellation endpoint available under /fulfillments/{fulfillment_id}/cancel.json that hadn't been implemented and serves as a replacement to the old /orders/{order_id}/fulfillments/{fulfillment_id}/cancel.json endpoint which has since been removed.

As of ShopifySharp 5.19.0 there doesn't seem to be a way (from what I could find?) to cancel a fulfilment.

The old CancelAsync method could probably be reimplemented using the new endpoint and a slightly different signature to match the new parameters.

@nozzlegear
Copy link
Owner

Thanks! I don't often work with fulfillments, so just want to confirm: the FulfillmentOrderService.CancelAsync method does not do what you need it to do?

@thomotron
Copy link
Contributor Author

Correct. The cancel endpoint for fulfilment orders is to cancel the fulfilment order as a whole rather than one single fulfilment.

The scenario I came across where this would be necessary is when cancelling a partially fulfiled order. If a fulfilment order has been closed successfully the API won't let you cancel it until you cancel the individual fulfilments assigned to the it. Once they're gone the fulfilment order becomes obsolete and the order can be cancelled.

thomotron added a commit to thomotron/ShopifySharp that referenced this issue Jan 31, 2023
thomotron added a commit to thomotron/ShopifySharp that referenced this issue Jan 31, 2023
thomotron added a commit to thomotron/ShopifySharp that referenced this issue Jul 10, 2023
@nozzlegear
Copy link
Owner

After a very long delay, this is now released in ShopifySharp v6.1.2. Thanks!

@nozzlegear nozzlegear linked a pull request Jul 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants