-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancel fulfilment endpoint missing after upgrade to 2022-07 #833
Comments
Thanks! I don't often work with fulfillments, so just want to confirm: the |
Correct. The cancel endpoint for fulfilment orders is to cancel the fulfilment order as a whole rather than one single fulfilment. The scenario I came across where this would be necessary is when cancelling a partially fulfiled order. If a fulfilment order has been closed successfully the API won't let you cancel it until you cancel the individual fulfilments assigned to the it. Once they're gone the fulfilment order becomes obsolete and the order can be cancelled. |
Implements nozzlegear#833
Implements nozzlegear#833
Implements nozzlegear#833
After a very long delay, this is now released in ShopifySharp v6.1.2. Thanks! |
As part of the upgrade to 2022-07, several deprecated fulfilment endpoints were removed (see af14afb) including
CancelAsync
. However, there was another cancellation endpoint available under/fulfillments/{fulfillment_id}/cancel.json
that hadn't been implemented and serves as a replacement to the old/orders/{order_id}/fulfillments/{fulfillment_id}/cancel.json
endpoint which has since been removed.As of ShopifySharp 5.19.0 there doesn't seem to be a way (from what I could find?) to cancel a fulfilment.
The old
CancelAsync
method could probably be reimplemented using the new endpoint and a slightly different signature to match the new parameters.The text was updated successfully, but these errors were encountered: