Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement fulfilment cancel endpoint #834

Merged

Conversation

thomotron
Copy link
Contributor

@thomotron thomotron commented Jan 31, 2023

Implements the fulfilment cancellation endpoint described in #833.

There was still a leftover code snippet in the README for the old method that has since been removed, so I just clipped out the order ID parameter to make it match this implementation.

@thomotron thomotron changed the title Feature/cancel fulfillment endpoint Reimplement fulfilment cancel endpoint Jan 31, 2023
@nozzlegear
Copy link
Owner

I need to confirm, is this still a supported API endpoint in Shopify's API version 2023-01?

@thomotron
Copy link
Contributor Author

It is yes. I've just given it a test and it's still available all the way to 2023-10.

@thomotron thomotron force-pushed the feature/cancel-fulfillment-endpoint branch from b946d87 to 2e7d906 Compare July 10, 2023 01:47
@rogulenkoko
Copy link

Could you say when you are going to merge this pull request?

@nozzlegear nozzlegear merged commit 57ee301 into nozzlegear:master Jul 12, 2023
@nozzlegear
Copy link
Owner

@rogulenkoko Merging and releasing now!

@nozzlegear
Copy link
Owner

Sorry, tests were taking a while to finish up and I had to run to a vet appointment. It's released now in ShopifySharp v6.1.2 on Nuget! Thanks for your patience everyone, and thanks for the pull request @thomotron!

@nozzlegear nozzlegear added the missing or invalid endpoints Issues dealing with a Shopify API endpoints implemented by ShopifySharp services. label Jul 13, 2023
@nozzlegear nozzlegear linked an issue Jul 13, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing or invalid endpoints Issues dealing with a Shopify API endpoints implemented by ShopifySharp services.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancel fulfilment endpoint missing after upgrade to 2022-07
5 participants