Staging #129
Merged
Staging #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add config for coveralls/simplecov and factory girl
Features/initial user model
created initial PasswordResetsController and interactors. Specs currently red. Added password to User factory, this is duplicated in other branches.
Features/initial group model
add GroupsController#index and acceptance specs for Group
add JSON schema validation to controller spec, create IndexGameNight interactor, fix update_game_night to return a game_night
…-join-tables add tests for Group join table creation
complete game_night acceptance specs
Tasks/join table acceptance specs
Features/roles and policies
|
Also, would you mind checking over all the commits and make sure I didn't miss anything 😆 (just kidding) |
| include BCrypt | ||
|
|
||
| TOKEN_KEY = Rails.application.secrets.secret_key_base | ||
| TOKEN_HASH = "SHA512" |
There was a problem hiding this comment.
Freeze mutable objects assigned to constants.
|
I just finished looking over all of the commits one-by-one. I noticed a critical bug and we will now have to start all over... from scratch. 🐛 |
|
P.S.: JK! Looks awesome @npauzenga!!! |
npauzenga
added a commit
that referenced
this pull request
Feb 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @enriikke! Bam! App. Done.
...for this weekend 😄
The basic functionality is there. Users can create accounts (and update/delete), view other users, create groups, game nights, join groups and game nights, and generally be merry.
So tomorrows our last meeting 😞 If you wouldn't mind checkout out the other open PR with the "question" label -- #125 and maybe we could look at that.
Also it'd be nice to talk through my deployment strategy. I've got it up on heroku -- https://meet-meeples-staging.herokuapp.com/ (that's staging) but I'd like to discuss the plan for hosting the front-end and having them play nicely.