-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging #129
Conversation
add config for coveralls/simplecov and factory girl
Features/initial user model
created initial PasswordResetsController and interactors. Specs currently red. Added password to User factory, this is duplicated in other branches.
Features/initial group model
add GroupsController#index and acceptance specs for Group
add JSON schema validation to controller spec, create IndexGameNight interactor, fix update_game_night to return a game_night
…-join-tables add tests for Group join table creation
complete game_night acceptance specs
Tasks/join table acceptance specs
Features/roles and policies
Also, would you mind checking over all the commits and make sure I didn't miss anything 😆 (just kidding) |
include BCrypt | ||
|
||
TOKEN_KEY = Rails.application.secrets.secret_key_base | ||
TOKEN_HASH = "SHA512" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Freeze mutable objects assigned to constants.
I just finished looking over all of the commits one-by-one. I noticed a critical bug and we will now have to start all over... from scratch. 🐛 |
P.S.: JK! Looks awesome @npauzenga!!! |
Hey @enriikke! Bam! App. Done.
...for this weekend 😄
The basic functionality is there. Users can create accounts (and update/delete), view other users, create groups, game nights, join groups and game nights, and generally be merry.
So tomorrows our last meeting 😞 If you wouldn't mind checkout out the other open PR with the "question" label -- #125 and maybe we could look at that.
Also it'd be nice to talk through my deployment strategy. I've got it up on heroku -- https://meet-meeples-staging.herokuapp.com/ (that's staging) but I'd like to discuss the plan for hosting the front-end and having them play nicely.