Features/group-interactors #83
Conversation
| @@ -1,2 +1,13 @@ | |||
| class CreateGroup < StandardInteraction | |||
| def validate_input | |||
| context.fail!(errors: "invalid input") unless context.group_params | |||
There was a problem hiding this comment.
@enriikke so now that I've done a few Interactors in this way (using validate_input, execute, validate_output) I'm sort of wondering if this might not be ideal. I was initially thinking that I'd want validate_input to do some more complex validation but in reality I end up just checking, in all of my Interactors, that the parameters are correct.
Do you think we'd be better served by a simple initialize method in each Interactor that would then throw an ArgumentError if something wasn't provided? It seems like if I did that I wouldn't need to define a new error if the params aren't provided BUT it would throw that error right away, not giving my controller a chance to serialize/render the JSON response.
There was a problem hiding this comment.
So I think the new error handling in #95 covers this a bit better. But I suppose I could override initialize with more explicit arguments i.e.
initialize(user_params, id)
...
endto maybe throw an argument error if it's not called with the correct arguments.
There was a problem hiding this comment.
I really love how you are working on improving this. I think specifying the required input as parameters would work great. You might need to figure out how to generalize that though, so that it can be applied to all interactions. Or maybe is just something that every interaction defines on its own.
|
|
||
| def execute | ||
| context.group = context.user.groups.create(context.group_params) | ||
| end |
There was a problem hiding this comment.
@enriikke I think this is the cleanest way to create a Group and a UserGroupMembership at the same time. context.user is my current_user, which I think is alright and I can't think of an instance where that will be a problem right now but perhaps you have thoughts?
There was a problem hiding this comment.
I think this works great. In theory, if we needed to reuse this interaction for an admin (so that they could create groups for any given user), they can call this interaction and pass in any user needed.
|
Awesome work @npauzenga!!! 🍶 🚢 💺 |
Hey @enriikke. I presume this will be the last PR before power (and hope) are lost. Once mankind re-builds we can resume.
Good luck out there, hope to see ya on the other side.
fixes #75