Buffer over-read with ArrayNullabilityMode.PerInstance (#5675)

Fixes #5674
npgsql · Apr 21, 2024 · 5fd00dd · 5fd00dd
1 parent 58b9a1b
commit 5fd00dd
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/Npgsql/Internal/Converters/ArrayConverter.cs b/src/Npgsql/Internal/Converters/ArrayConverter.cs
@@ -630,6 +630,12 @@ public PolymorphicArrayConverter(PgConverter<TBase> structElementCollectionConve
         _nullableElementCollectionConverter = nullableElementCollectionConverter;
     }
 
+    public override bool CanConvert(DataFormat format, out BufferRequirements bufferRequirements)
+    {
+        bufferRequirements = BufferRequirements.Create(read: sizeof(int) + sizeof(int), write: Size.Unknown);
+        return format is DataFormat.Binary;
+    }
+
     public override TBase Read(PgReader reader)
     {
         _ = reader.ReadInt32();