Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pruning enable/disable race condition #4255

Merged
merged 1 commit into from Dec 30, 2021
Merged

Conversation

roji
Copy link
Member

@roji roji commented Dec 30, 2021

Fixes #3407

Inspired by @shortspider in #4230

@roji roji requested a review from vonzshik as a code owner December 30, 2021 14:59
@roji roji merged commit 810ef70 into npgsql:main Dec 30, 2021
@roji roji deleted the FixPruning branch December 30, 2021 17:24
roji added a commit that referenced this pull request Dec 30, 2021
@roji
Copy link
Member Author

roji commented Dec 30, 2021

Backported to 6.0.3 via a571f68
Backported to 5.0.12 via e31c4a3
Backported to 4.1.11 via b261b12

roji added a commit that referenced this pull request Dec 30, 2021
roji added a commit that referenced this pull request Dec 31, 2021
@baal2000
Copy link
Contributor

@roji
This is a pretty annoying issue for us, unfortunately. What is the timeline for publishing 6.0.3 and 5.0.12?

@roji
Copy link
Member Author

roji commented Jan 21, 2022

6.0.3 will be probably be published next week, I'll see about publishing 5.0.12 as well.

@baal2000
Copy link
Contributor

@roji
Thanks for 6.0.3 nuget. What is 5.0.12 ETA?

@roji
Copy link
Member Author

roji commented Feb 1, 2022

@baal2000 I've just released 5.0.12, which contains this fix.

@Voodoolmar
Copy link

@roji
Thanks for 6.0.3 and 5.0.12 nuget. What is 4.1.11 ETA?
Thanks in advance.

@baal2000
Copy link
Contributor

baal2000 commented Mar 1, 2022

@Voodoolmar
RE: #4230 (comment)

Did 4.1.11 fix work for you?

@Voodoolmar
Copy link

@baal2000 Last nuget package 4.1.10. Didnt try.

vonzshik pushed a commit that referenced this pull request Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConnectorPool's pruning timer isn't thread safe
4 participants