Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement multiplexing via NpgsqlDataSource.CreateCommand #4496

Open
Tracked by #3991 ...
roji opened this issue Jun 1, 2022 · 2 comments · May be fixed by #4839
Open
Tracked by #3991 ...

Reimplement multiplexing via NpgsqlDataSource.CreateCommand #4496

roji opened this issue Jun 1, 2022 · 2 comments · May be fixed by #4839
Assignees
Milestone

Comments

@roji
Copy link
Member

roji commented Jun 1, 2022

Once NpgsqlDataSource is integrated, we can reimplement multiplexing

  • This represents multiplexing exactly where it is API-wise: at the database/pool level, not associated to any particular connection instance.
  • This would make it impossible to accidentally depend on connection state, which isn't supported in multiplexing (e.g. 45270fa)
  • It would considerably simplify our internal code, since we'll no longer have to deal with bound/unbound connections - connections are always bound. Instead we'd just have a MultiplexingNpgsqlCommand (internal type) which implements the multiplexing logic.
  • I think we still want multiplexing to be opt-in on the connection string.

Note: if we no longer support multiplexing on NpgsqlConnection (which we ideally shouldn't), then EF Core and other layers must react and use DbDataSource in order to get the perf benefits of multiplexing.

@diipak-bisht

This comment was marked as off-topic.

@roji

This comment was marked as off-topic.

@roji roji modified the milestones: 8.0.0, 9.0.0 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants