Drop support for parentheses in CommandType=StoredProcedure

[roji]

Did some cleanup work and wasn't sure about something...

In 2.2 we currently allow executing a StoredProcedure with parentheses:

var command = new NpgsqlCommand("funcC()", Conn);
command.CommandType = CommandType.StoredProcedure;

Many of our unit tests are written this way.

I know there were some discussions about this (#296) but am not sure of the result.

• The MSDN docs clearly say that "the CommandText property should be set to the name of the stored procedure to be accessed.
• Are parameters supported or just open/close parentheses (and should they be)?
• Should we keep supporting this? Is it too much breakage to remove it?

[franciscojunior]

I don't remember exactly why we allowed parameters in the text when the command type is set to storedprocedure. :(

I think we should support as stated in the msdn docs: just the name of the stored procedure.

In order to help with the cleanup, I created #449 some time ago which has a lot of changes in the tests to remove the parameters and parentheses from the command text.

[roji]

Ah OK, thanks for the quick answer :)

I'll start looking at function support soon, and will remove the parentheses. I'll also look at your PR.

Thanks!