-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing Association/AssociationSet(aka FK constraints) in the EF manifest files #119
Conversation
Hi, Kenji! Do you think those changes have any impact in the database creation support added by #91 ? |
Hi. I have added a test TestSchemaInformation to check the usability of EntityFramework provider manifest. The SchemaInformation is to see reverse engineered objects from db, such as tables/constraints/functions/etc. The test just checks object's existance generated by TestFixtureSetup. |
@franciscojunior and @kenjiuno, this PR is marked as open and scheduled for 2.2, are we waiting for anything on this? Or has it been superceded by #213? |
I also don't know if it has been superceded by #213. |
Hi. This pr is not related with ddex working. It fixes some missing relations. As a result, tools like EdmGen can discover functions and stored procedures and so on. |
OK, thanks @kenjiuno! Do you still need work on this, is it waiting review, or can it be merged? Is it tested/safe enough for inclusion in 2.2? |
Hi. I have no plan to improve this for now. It is completed. And it needs review. However I think anyone may not need it. So, no one can review it... I will wait for comments from someone. EF6 and Npgsql will work well without this pr. So, please skip this pr in 2.2. |
0b35ef0
to
c43b6af
Compare
e1d8c57
to
1f140e5
Compare
1236d1f
to
e8ae2e0
Compare
19a99a1
to
2fc8944
Compare
33651f5
to
e880d97
Compare
I will close this pr for a moment. |
This is updated PR from #100, targeting new 2.1.0 branch.
It adds missing relationships between entities, into the EntityFramework provider manifest.
New AssociationSets in ssdl (table to table?):
New Associations in ssdl (column to column?):
I have figured current status to check missing ones.
https://dl.dropboxusercontent.com/u/24560712/ef6/fixed_npgsql_msl_ssdl.png
Currently EdmGen fails to generate correct schema for target database, because associations are missing. e.g. Table has no TableColumns.