Fixed auto prepared statement is wrongfully replaced by other statement. #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohDeadfall
approved these changes
Jul 8, 2019
|
@JustBSka apologies for not looking at this previously, this slipped under my radar. I analyzed the error, and it seems better to catch the error when it occurs and properly update the bookkeeping, rather than leaving the failing prepared statement in a BeingPrepared state and handling that on the next command. Submitted #2516 to implement that. If you have time to take a look at #2516, that would be great. |
|
Superceded by #2516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2178
Faulty statement stays in "BeingPrepared" state and replaces another prepared statement.