Recycle NpgsqlTransaction #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
force-pushed
the
RecycleTransaction
branch
from
147b5ca
to
cf15d95
Compare
YohDeadfall
approved these changes
Apr 17, 2019
|
@roji Could you rebase this when you have a chance? |
austindrenski
approved these changes
May 14, 2019
There was a problem hiding this comment.
In the end I think the logic is actually simplified
Definitely agree, nice work on this @roji!
Since PostgreSQL only supports on transaction on a given connection, we reycle the NpgsqlTransaction object. Closes npgsql#2416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PostgreSQL only supports on transaction on a given connection, we reycle the NpgsqlTransaction object.
Closes #2416
@YohDeadfall @austindrenski the lifecycle changes here aren't exactly trivial, so I'd appreciate a good review. In the end I think the logic is actually simplified, since the NpgsqlTransaction's state simply mirrors the connector's TransactionStatus (except for disposal, which is still managed on the NpgsqlTransaction since it's user-controlled).