Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to a better matching engine (leven) #1071

Closed
wants to merge 1 commit into from
Closed

chore: migrate to a better matching engine (leven) #1071

wants to merge 1 commit into from

Conversation

jamesgeorge007
Copy link
Contributor

What / Why

meant is not actively maintained anymore. It would be a good idea to migrate to leven.

References

closes #1032

@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner March 28, 2020 08:35
@ruyadorno
Copy link
Contributor

hi @jamesgeorge007 thank you so much for the contribution! 😄

Following up from the discussion in the original issue. I'd like to check and see if you still intend to follow up with this PR? Now that the v7 beta is out it's def a good timing 😊

In case you intend to give this migration another try, I would advise you to start over from the release/v7.0.0-beta branch and add some unit tests (which should be way simpler now!). For references/examples check the new unit tests at test/lib/ folder.

@ruyadorno ruyadorno added Enhancement new feature or improvement Needs Discussion is pending a discussion pr: needs tests requires tests before merging Release 7.x work is associated with a specific npm 7 release labels Aug 14, 2020
@jamesgeorge007
Copy link
Contributor Author

Hey thanks, I'll look into it :)

@jamesgeorge007 jamesgeorge007 changed the base branch from latest to release/v7.0.0-beta August 15, 2020 14:36
@jamesgeorge007 jamesgeorge007 force-pushed the dep-migration branch 2 times, most recently from dcb3f8c to 7931520 Compare August 15, 2020 15:29
isaacs pushed a commit that referenced this pull request Aug 18, 2020
@jamesgeorge007 @isaacs
chore: migrate to leven
9e7cc42 
Credit: @jamesgeorge007
PR-URL: #1071
Close: #1071
Reviewed-By: @isaacs

EDIT(@isaacs): changed dependency in a separate commit
@ruyadorno
Copy link
Contributor

Merged in the npm:release/v7.0.0-beta branch ✅

Thanks @jamesgeorge007!

@ruyadorno ruyadorno closed this Aug 18, 2020
@jamesgeorge007 jamesgeorge007 deleted the dep-migration branch August 19, 2020 03:12
@watilde
Copy link
Contributor

watilde commented Oct 26, 2020 •
edited
Loading

Sorry to hear that meant doesn't seem to be active anymore even meant was updated 3 months ago and leven was updated 2 years ago. JFYI, I'm happy to migrate meant's repository to npm's org anytime if it helps.

Let me follow up on the issue.

@watilde watilde mentioned this pull request Oct 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement new feature or improvement Needs Discussion is pending a discussion pr: needs tests requires tests before merging Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to a better matching engine
3 participants
@jamesgeorge007 @ruyadorno @watilde