fix: remove unused broken require #1661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I totally missed this, I just opened a dupe Based on the patterns in npm (and the fact that people use it on versions of node > 10.x I think that the solution I proposed is a bit better)... closing my PR and making a suggested change ehre |
MylesBorins
reviewed
Aug 12, 2020
|
Just a heads up to @ruyadorno, this fix should include updating npm-registry-fetch to v.4.0.6 that had the same bug. |
ruyadorno
added
Release 6.x
ruyadorno
pushed a commit
that referenced
this pull request
Aug 17, 2020
Fixes: #1658 PR-URL: #1661 Credit: @aduh95 Close: #1661 Reviewed-by: @ruyadorno
ruyadorno
pushed a commit
that referenced
this pull request
Aug 17, 2020
Fixes: #1658 PR-URL: #1661 Credit: @aduh95 Close: #1661 Reviewed-by: @ruyadorno
ruyadorno
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes: #1658