chore: mitigate security advisory 886 #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node-gyp@3.8.0 uses fstream@1.0.11, which has this advisory: https://www.npmjs.com/advisories/886 node-gyp@4.0.0 uses fstream@1.0.12, which has resolved the issue
npm-lifecycle@2.1.0 also depends on node-gyp@3.8.0. Bumping to npm-lifecycle@2.1.1 addresses the issue
hughrawlinson
changed the title
|
Would be great to get this looked at, as |
3 tasks
|
Bumping to node-gyp v4 will take some more refactoring, but the fstream vuln will be fixed in the next release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-gyp@3.8.0 uses fstream@1.0.11, which has this advisory: https://www.npmjs.com/advisories/886
node-gyp@4.0.0 resolved that vulnerability by removing dependencies on fstream.
I also bumped npm-lifecycle@2.1.0 to 2.1.1, which does the same as above.
The tests don't pass locally, but I'm hoping the reasons why become more clear by running on CI, so that I can resolve them.
Please feel free to close this if it doesn't make sense for some reason I haven't thought of (or of course for any other reason). Thank you all for all you do! 馃槃