Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docs-clean from the publish make target #2357

Closed

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Dec 15, 2020

References

@isaacs isaacs requested a review from a team as a code owner December 15, 2020 19:48
@isaacs isaacs requested a review from nlf December 15, 2020 19:48
@npm-deploy-user
Copy link

angular-quickstart app-large app-medium ember-quickstart react-app
prev current status prev current status prev current status prev current status prev current status
initial install 41s 45.7s🛑 39.5s 49.1s🛑 34.5s 35.3s✅🐌 28.1s 31.2s🛑 33.5s 41.2s🛑
repeat install 9.6s 3.4s 8.6s 3.5s 8.3s 2.9s 7.7s 1.8s 9.1s 3s
with warm cache 32.3s 25.8s 33.8s 31.7s 31.3s 21.8s 23.4s 18.8s 29.1s 21s
with node_modules 9.2s 6.3s 8.6s 4.9s 9s 4s 7.8s 2.2s 9.4s 6.3s
with lockfile 32.6s 32.1s 31s 33.5s✅🐌 29s 22.7s 21.7s 20.4s 27.4s 28.1s✅🐌
with warm cache and node_modules 9.3s 3.7s 7.9s 3.9s 8.4s 3.1s 7.6s 2s 9.2s 3.3s
with warm cache and lockfile 24.7s 10.9s 26.3s 14.6s 24.3s 9.1s 17.8s 6.9s 21.3s 7.9s
with node_modules and lockfile 10.1s 5.8s 9.8s 4.8s 8.6s 3.6s 7.8s 1.9s 9.7s 6.1s

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Dec 16, 2020
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, no reason to drop the docs and rebuild the world 👍

@isaacs isaacs changed the base branch from latest to release/v7.3.0 December 18, 2020 19:18
isaacs added a commit that referenced this pull request Dec 18, 2020
@isaacs isaacs closed this Dec 18, 2020
@isaacs isaacs force-pushed the isaacs/faster-make-publish-no-docs-clean branch from be4a0a5 to c6775ef Compare December 18, 2020 19:18
@nlf nlf deleted the isaacs/faster-make-publish-no-docs-clean branch March 28, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants