Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exec): ignore packageLockOnly flag #4843

Merged
merged 1 commit into from May 3, 2022
Merged

Conversation

nlf
Copy link
Contributor

@nlf nlf commented May 3, 2022

this flag can cause npx/npm exec to fail to install missing packages correctly, so we forcibly turn it off

replaces #4649
closes #4595

@nlf nlf requested a review from a team as a code owner May 3, 2022 18:49
@npm-robot
Copy link
Contributor

npm-robot commented May 3, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 59.858 ±2.69 36.053 ±0.50 20.171 ±0.12 23.082 ±0.85 3.191 ±0.05 3.333 ±0.07 2.571 ±0.01 13.327 ±0.44 2.423 ±0.02 3.459 ±0.01
#4843 59.729 ±6.17 33.810 ±0.99 19.874 ±0.11 21.812 ±0.57 3.088 ±0.03 3.117 ±0.00 2.436 ±0.02 12.793 ±0.23 2.425 ±0.01 3.622 ±0.19
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 39.753 ±1.86 26.038 ±0.23 14.023 ±0.19 15.193 ±0.13 2.799 ±0.01 2.800 ±0.02 2.454 ±0.02 9.038 ±0.08 2.308 ±0.01 3.192 ±0.04
#4843 40.999 ±1.23 25.891 ±0.34 14.121 ±0.10 14.908 ±0.25 2.868 ±0.01 2.963 ±0.03 2.557 ±0.08 9.212 ±0.01 2.382 ±0.01 3.294 ±0.01

@nlf nlf force-pushed the nlf/disable-flags-for-exec branch from 2f2916b to 8ebaea8 Compare May 3, 2022 20:35
@nlf nlf changed the title fix(exec): ignore packageLock and packageLockOnly flags fix(exec): ignore packageLockOnly flag May 3, 2022
@nlf nlf merged commit b9a966c into latest May 3, 2022
@nlf nlf deleted the nlf/disable-flags-for-exec branch May 3, 2022 20:53
@nlf nlf mentioned this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] preinstall script with npx does not work with --package-lock-only
3 participants