Skip to content
This repository has been archived by the owner on Nov 16, 2019. It is now read-only.

Dont send body if empty #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dont send body if empty #12

wants to merge 2 commits into from

Conversation

alh3im
Copy link

@alh3im alh3im commented Jan 27, 2015

For some custom install of couchdb app, if body is empty, connection may be reset by peer.

Example with the npm registry couchapp.

@alh3im
Copy link
Author

alh3im commented Jan 28, 2015

I've added a new commit with cancel the first one.

@isaacs
Copy link
Contributor

isaacs commented Jan 28, 2015

Can you please add some tests for this?

@alh3im
Copy link
Author

alh3im commented Jan 29, 2015

Do you mean unit tests or manual functional tests ?

@isaacs
Copy link
Contributor

isaacs commented Jan 29, 2015

I mean unit tests, like the ones in /test/*.js. You can probably piggie-back on an existing test, just make a request like the one where you found this. Make sure the test fails without the patch, and passes with the patch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants