Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update staging deployment flow #173

Merged
merged 1 commit into from
Aug 17, 2022
Merged

docs: update staging deployment flow #173

merged 1 commit into from
Aug 17, 2022

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Aug 12, 2022

This updates the docs to show how the staging deployments for this site now work. See this comparison for the changes to CI.

Notable changes:

  • pull_request_target is included in the main publish.yml workflow. That event controls which ref is checked out and whether the deploy job is a preview or not.
  • For all other events, main is explicitly checked out. This allows us to push commits when fetching/updating the CLI docs, and then the call the publish.yml as a reusable workflow but still have it deploy the latest.
  • stage-pull-request.yml has been removed and all deployments (production and preview) occur in this repo

These changes are already in use, but I will leave this PR open for visibility and discussion.

/cc @MylesBorins

@lukekarrys lukekarrys merged commit 575286a into main Aug 17, 2022
@lukekarrys lukekarrys deleted the lk/staging-docs branch August 17, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants