Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate name: prompt #69

Closed
wants to merge 1 commit into from
Closed

Conversation

addaleax
Copy link
Contributor

Hi there! 👋

While working through the how-to-npm Nodeschool workshopper it
was discovered that the name: prompt is a bit confusing for
newcomers, as it could also be interpreted as referring to the
npm account name (or similar). This changes the prompt to use
package name:.

While working through the `how-to-npm` Nodeschool workshopper it
was discovered that the `name:` prompt is a bit confusing for
newcomers, as it could also be interpreted as referring to the
npm account name (or similar). This changes the prompt to use
`package name:`.
@isaacs isaacs added the review label Mar 28, 2017
Copy link

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! thanks for this, that confusion makes a lot of sense and i've run into it while teaching before!

@ashleygwilliams
Copy link

@zkat @iarna making sure ya'll see this as bumping this would be CLI work

iarna pushed a commit that referenced this pull request Apr 20, 2017
While working through the `how-to-npm` Nodeschool workshopper it
was discovered that the `name:` prompt is a bit confusing for
newcomers, as it could also be interpreted as referring to the
npm account name (or similar). This changes the prompt to use
`package name:`.

PR-URL: #69
@iarna
Copy link
Contributor

iarna commented Apr 20, 2017

Hey, thanks for this. It's been merged and released in v1.10.0.

@iarna iarna closed this Apr 20, 2017
@iarna iarna removed the review label Apr 20, 2017
@addaleax addaleax deleted the name-prompt branch April 21, 2017 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants