feat(git): add support for :: in #committish #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This iterates on the spec outlined by @coreyfarrel in #46. For each :: separated item: * If the item has no : then it is a commit-ish * If the item has : then split into name and value. * If the name is semver then do semver lookup of ref or tag * If the name is path then use the value as the subdir to install from. * If the name is unknown then warn that the name-value pair is being ignored. This loop errors if duplicate values are found. Unknown values log a warning instead of erroring.
wraithgar
changed the title
|
ahhhhhh shieeeet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds off of #46, and
more specifically the spec laid out by @coreyfarrell. Namely:
For each :: separated item:
This loop errors if duplicate values are found.
Unknown values log a warning instead of erroring.
This also introduces the concept of a
pathspecifier that is assignedto the
gitSubdirattribute. Consuming libs (e.g. pacote) will need tolook for that and react to its presence accordingly.
Credit: @sspiff for the original PR and @coreyfarrell for the spec