Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: A files list should not exclude bundled dependencies #46

Closed

Conversation

evocateur
Copy link
Contributor

What / Why

This preserves npm v6 behavior when both files and bundleDependencies are configured in the root manifest. While one could workaround this by adding an explicit 'node_modules' to the files list, there is currently no error to indicate this necessity and it yields a frustrating silent error.

References

@mikemimik mikemimik added Backlog a "backlogged" item that will be tracked in a Project Board Release 7.x labels Dec 17, 2019
@darcyclarke darcyclarke added Agenda will be discussed at the Open RFC call Needs Discussion is pending a discussion labels Dec 17, 2019
@evocateur
Copy link
Contributor Author

I guess this was fixed in d9b751e. Would have been nice to be notified.

@evocateur evocateur closed this Jan 19, 2020
@evocateur evocateur deleted the fix-bundled-with-explicit-files branch January 19, 2020 20:56
@darcyclarke darcyclarke removed the Agenda will be discussed at the Open RFC call label Jan 22, 2020
@isaacs
Copy link
Contributor

isaacs commented Jan 26, 2020

@evocateur Sorry, I think I ran into this a few weeks ago myself when working on Arborist.reify, and just fixed the bug without stopping to check if there was a PR for it already.

@evocateur
Copy link
Contributor Author

@isaacs I completely understand, despite my crabby passive-aggressive comment, for which I apologize. I am reminding myself to work on my empathy, which should have been more evident, especially toward a fellow maintainer.

Thanks for all the work you've been putting into npm lately, it's exciting. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backlog a "backlogged" item that will be tracked in a Project Board Needs Discussion is pending a discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] v2 does not include bundleDependencies if has files
4 participants