This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
Decode the package name from the request URL #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test to this to catch regressions, and also to document what the registry is likely to be sending? A bunch of the existing tests show how to use the existing (built-in, not |
Present the decoded package name in the error message if present.
Fixes npm/registry-frontdoor#116.
Fixes npm/npme-auth-userapi#16.
othiym23
force-pushed
the
decode-error-package-name
branch
from
5fc6268
to
2e1b2a5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Present the decoded package name in the error message if present.
Fixes npm/registry-frontdoor#116.
Fixes npm/npme-auth-userapi#16.