fix: added regex for blocking illegal characters in usernames #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdickinson
suggested changes
Oct 20, 2016
|
|
||
| var illegalCharacterRe = new RegExp('([' + [ | ||
| "'" | ||
| ].join(',') + '])') |
There was a problem hiding this comment.
I think ',' may be incorrect here?
|
@iarna looping you in because BIG HUGE EFFECT maybe |
iarna
approved these changes
Apr 21, 2017
There was a problem hiding this comment.
Bleeergh, ok, so, the concern here is that users of third party registries might be using usernames that conflict with this. Ok, probably not, but it could happen. =D
So, given that, I'm going to take this as a breaking change and we can include it npm@5. Just the same, if we do end up getting reports from third party registries then we will likely revert it, but I don't consider that likely.
|
Conveniently, we haven't had a 1.0 release yet, so 1.0.0 it is I guess. =D |
|
Released as 1.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
We ran into an issue recently where single-quotes (
') were accepted bynpm-user-validate, but rejected by CouchDB.Linux and OSX systems do not play nice with
'in folder paths; and I think the correct solution is black-listing this character.The Solution
I've added a regex that allows us to black-list specific illegal characters, starting with
'.To make sure I was writing appropriate tests, etc., I've upgraded
tapand turned on coverage; I've also added Travis CI testing for modern Node.js.