Use path-is-inside@1.0.0 to fix #4313.

npm · Dec 14, 2013 · 5ec425c · 5ec425c
1 parent 9de0716
commit 5ec425c
Show file tree

Hide file tree

Showing 6 changed files with 117 additions and 6 deletions.
diff --git a/lib/cache.js b/lib/cache.js
@@ -83,6 +83,7 @@ var mkdir = require("mkdirp")
   , chmodr = require("chmodr")
   , which = require("which")
   , isGitUrl = require("./utils/is-git-url.js")
+  , pathIsInside = require("path-is-inside")
 
 cache.usage = "npm cache add <tarball file>"
             + "\nnpm cache add <folder>"
@@ -1253,7 +1254,3 @@ function needVersion(er, data) {
        : (data && !data.version) ? new Error("No version provided")
        : null
 }
-
-function pathIsInside (potentialChild, parent) {
-  return path.relative(parent, potentialChild).indexOf('..') === -1
-}
diff --git a/node_modules/path-is-inside/LICENSE.txt b/node_modules/path-is-inside/LICENSE.txt
diff --git a/node_modules/path-is-inside/README.md b/node_modules/path-is-inside/README.md
diff --git a/node_modules/path-is-inside/lib/path-is-inside.js b/node_modules/path-is-inside/lib/path-is-inside.js
diff --git a/node_modules/path-is-inside/package.json b/node_modules/path-is-inside/package.json
diff --git a/package.json b/package.json
@@ -78,7 +78,8 @@
     "github-url-from-username-repo": "0.0.2",
     "text-table": "~0.2.0",
     "ansicolors": "~0.3.2",
-    "ansistyles": "~0.1.3"
+    "ansistyles": "~0.1.3",
+    "path-is-inside": "~1.0.0"
   },
   "bundleDependencies": [
     "semver",
@@ -127,7 +128,8 @@
     "normalize-package-data",
     "text-table",
     "ansicolors",
-    "ansistyles"
+    "ansistyles",
+    "path-is-inside"
   ],
   "devDependencies": {
     "ronn": "~0.3.6",