-
Notifications
You must be signed in to change notification settings - Fork 3k
Implement reminder if using run/run-script without 'install' #10043
Conversation
…encies but without a node modules directory
@@ -3,6 +3,7 @@ module.exports = runScript | |||
var lifecycle = require('./utils/lifecycle.js') | |||
var npm = require('./npm.js') | |||
var path = require('path') | |||
var fs = require('fs') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well use graceful-fs
I think.
I wonder if this is best done here so that this warning only prints if a script actually failed to run. Also would: fs.stat(path.resolve(pkgdir, 'node_modules/'), ...) be "better" than having to do |
Will get onto it tomorrow, cheers!
|
This landed in 3.6.0! =) |
@timkrins I just encountered this, great work, very helpful! |
For #10032
Implements warning if using run/run-script with locally defined dependencies but without a node modules directory.
Need help writing tests - couldn't figure out how to achieve a pass/fail through using npm in tap.