This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Allow npm version to be run from subdirectories
#10627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekmartin
force-pushed
the
version_git_add
branch
from
3e8c0a8
to
7dcbd3c
Compare
|
I haven't had time to review this thoroughly, but if you think a note in the docs would be helpful, by all means add it! We'll try to get this into next week's releases. |
|
No problem! Not sure if an update to the docs is needed, but I'm not familiar with the differences of opinion you were mentioning here. If there's other results that would make sense when you run version from a subdirectory I agree that it probably should be clarified. |
othiym23
pushed a commit
that referenced
this pull request
Dec 11, 2015
|
Landed for |
othiym23
pushed a commit
that referenced
this pull request
Dec 11, 2015
|
Cherry-picked for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9099 by using the local
package.jsonpath when runninggit add. Was this something like what you were thinking of @othiym23? If it was I can add a small description of the behavior to the docs, just wanted to check first.