Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Updated documentation for bundledDependencies #11483

Closed
wants to merge 1 commit into from
Closed

Updated documentation for bundledDependencies #11483

wants to merge 1 commit into from

Conversation

gnerkus
Copy link
Contributor

@gnerkus gnerkus commented Feb 9, 2016

What?
I added a description of the functionality of the bundledDependencies attribute of a package.json file.

Why?
To help explain its usefulness and reduce confusion.

Tests
All tests were completed successfully.

@othiym23 othiym23 added the review label Feb 9, 2016
@gnerkus gnerkus mentioned this pull request Feb 11, 2016
Closed
@iarna
Copy link
Contributor

iarna commented Feb 25, 2016

This is fantastic, thank you! LGTM

@iarna iarna added this to the next milestone Feb 25, 2016
@iarna iarna removed the review label Feb 25, 2016
@iarna iarna modified the milestones: next-next, next Feb 26, 2016
@iarna
Copy link
Contributor

iarna commented Feb 26, 2016

This landed in 3.8.0 as 4906c90. lts will land next week.

@gnerkus
Copy link
Contributor Author

gnerkus commented Feb 26, 2016

Thank you. I'm glad I could be of help.

I'll be sure to update npm when the new version is released.

zkat pushed a commit that referenced this pull request Mar 3, 2016
@gnerkus @zkat
doc: update documentation for bundledDependencies
a407ca2 
PR-URL: #11483
Credit: @gnerkus
Reviewed-By: @iarna
@iarna
Copy link
Contributor

iarna commented Mar 10, 2016

This landed in 2.14.22!

@iarna iarna closed this Mar 10, 2016
@kenany kenany mentioned this pull request Apr 5, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
merge-to-lts
Projects
None yet
Milestone
3.8.1 & 2.14.22
Development

Successfully merging this pull request may close these issues.
3 participants
@gnerkus @iarna @othiym23