This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
deps: dedupe deeply nested bundled modules #11527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current tree includes a bunch of nested modules which are causing the CI build for Node.js to not work on windows. A bit of forensics found that the tree in `npm/node_modules/npm-install-check/node_modules/npmlog/node_modules/gauge` is much larger in the latest release due to duplicated modules. This commit used npm@3 to dedupe node_modules/npm-install-check resulting in a much shallower tree. `npm ls` still runs cleanly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current tree includes a bunch of nested modules which are causing
the CI build for Node.js to not work on windows.
A bit of forensics found that the tree in
npm/node_modules/npm-install-check/node_modules/npmlog/node_modules/gaugeis much larger in the latest release due to duplicated modules.
This commit used npm@3 to dedupe node_modules/npm-install-check
resulting in a much shallower tree.
npm lsstill runs cleanlyI have testing this patch applied locally to the npm repo and
make test-npmpasses all green.I have also run "npm test" locally inside of the npm repo and we are getting all green with a single failure
test/tap/00-verify-bundle-deps.jswhich appears to be present on the head of 2.xedit: it is also worth mentioning that the node distro is building as expected in windows with this patch applied