Only list runtime dependencies when doing `npm ls --production` #11562

yibn2008 · 2016-02-16T12:26:30Z

othiym23 · 2016-02-16T16:38:37Z

@iarna, can you review this? This fixes more than just #11559, and has come up a few times recently.

iarna · 2016-02-16T20:07:26Z

lib/ls.js

+      return
+    }
+
+    if ((dev && devKeys.indexOf(name) >= 0) ||            // only --production


Am I misreading this or are the comments swapped between this line and the line following?

Oh ... yes, the comments should be swapped, it's a mistake.

iarna · 2016-02-16T20:16:18Z

Looks solid to me 🐑

@yibn2008

Fixes: #11559 Credit: @yibn2008 Reviewed-By: @iarna PR-URL: #11562

zkat · 2016-02-19T23:06:00Z

This was merged and included in npm@3.7.4. Thanks! :D

This is necessary for the `checkDevDependencies` option to work. See fix in: npm/npm#11562

othiym23 added the review label Feb 16, 2016

iarna reviewed Feb 16, 2016
View reviewed changes

iarna added the merge-to-latest label Feb 16, 2016

iarna added this to the next milestone Feb 16, 2016

fix npm#11559

e40734e

yibn2008 force-pushed the master branch from b52f4fd to e40734e Compare February 17, 2016 05:13

zkat removed the review label Feb 18, 2016

zkat changed the title ~~fix #11559~~ Only list runtime dependencies when doing npm ls --production Feb 18, 2016

iarna pushed a commit that referenced this pull request Feb 19, 2016

ls: Only list runtime dependencies when doing npm ls --production

8d90d25

Fixes: #11559 Credit: @yibn2008 Reviewed-By: @iarna PR-URL: #11562

zkat closed this Feb 19, 2016

chrishyle added a commit to chrishyle/find-duplicate-dependencies that referenced this pull request Mar 3, 2017

Bump NPM version to latest

9f12b4e

This is necessary for the `checkDevDependencies` option to work. See fix in: npm/npm#11562

chrishyle mentioned this pull request Mar 3, 2017

Bump NPM version to latest vovacodes/find-duplicate-dependencies#1

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only list runtime dependencies when doing `npm ls --production` #11562

Only list runtime dependencies when doing `npm ls --production` #11562

yibn2008 commented Feb 16, 2016

othiym23 commented Feb 16, 2016

iarna Feb 16, 2016

yibn2008 Feb 17, 2016

iarna commented Feb 16, 2016

zkat commented Feb 19, 2016

Only list runtime dependencies when doing npm ls --production #11562

Only list runtime dependencies when doing npm ls --production #11562

Conversation

yibn2008 commented Feb 16, 2016

othiym23 commented Feb 16, 2016

iarna Feb 16, 2016

Choose a reason for hiding this comment

yibn2008 Feb 17, 2016

Choose a reason for hiding this comment

iarna commented Feb 16, 2016

zkat commented Feb 19, 2016

Only list runtime dependencies when doing `npm ls --production` #11562

Only list runtime dependencies when doing `npm ls --production` #11562