This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
install: Use EXDEV aware move instead of rename #15901
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
'use strict' | ||
module.exports = wrappedMove | ||
|
||
var fs = require('graceful-fs') | ||
var move = require('@npmcorp/move') | ||
var Bluebird = require('bluebird') | ||
|
||
function wrappedMove (from, to, cb) { | ||
var movePromise = move(from, to, {fs: fs, Promise: Bluebird, maxConcurrency: 4}) | ||
if (cb) { | ||
return movePromise.then(function (value) { | ||
cb(value) | ||
}, function (err) { | ||
cb(err) | ||
}) | ||
} else { | ||
return movePromise | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,9 @@ | ||
'use strict' | ||
var fs = require('graceful-fs') | ||
var SaveStack = require('./save-stack.js') | ||
/* | ||
|
||
module.exports = rename | ||
This is a stub file to ensure that the following hack doesn't break. This can be removed w/ npm@5. | ||
|
||
function rename (from, to, cb) { | ||
var saved = new SaveStack(rename) | ||
fs.rename(from, to, function (er) { | ||
if (er) { | ||
return cb(saved.completeWith(er)) | ||
} else { | ||
return cb() | ||
} | ||
}) | ||
} | ||
# Fix bug https://github.com/npm/npm/issues/9863 | ||
RUN cd $(npm root -g)/npm \ | ||
&& npm install fs-extra \ | ||
&& sed -i -e s/graceful-fs/fs-extra/ -e s/fs\.rename/fs.move/ ./lib/utils/rename.js | ||
*/ |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
13 changes: 13 additions & 0 deletions
13
node_modules/@npmcorp/move/node_modules/@npmcorp/copy/LICENSE
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be worth leaving this as an empty file so it doesn't break anyone using:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm grumpy about it but yeah, since this is fixing things for exactly the folks who would have had that patch, we probably shouldn't break the work around. =D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll remove the hack w/ npm@5, since it's a breaking bump anyway.