This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Correctly save transitive dependencies #18846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
approved these changes
Oct 14, 2017
lib/install.js
Outdated
| this.rollback = npm.config.get('rollback') | ||
| this.link = npm.config.get('link') | ||
| this.global = this.where === path.resolve(npm.globalDir, '..') | ||
| this.dev = opts.dev != null ? opts.dev : npm.config.get('dev') || (!/^prod(uction)?$/.test(npm.config.get('only')) && !npm.config.get('production')) || /^dev(elopment)?$/.test(npm.config.get('only')) |
There was a problem hiding this comment.
Can I ask that we parenthesize, and maybe split between lines, all these different conditionals? I can never tell how it's actually supposed to parse when you do ternary + or + and all in on line >_<
There was a problem hiding this comment.
this change otherwise looks good
There was a problem hiding this comment.
er wow, yeah, that looks awful…
iarna
force-pushed
the
update-transitive-deps
branch
from
ebf9e76
to
bfb662c
Compare
Direct deps get `package.json` and `package-lock.json`. Transitive deps get `package-lock.json`.
iarna
force-pushed
the
update-transitive-deps
branch
from
bfb662c
to
88343f5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct deps get
package.jsonandpackage-lock.json. Transitive deps getpackage-lock.json.This is a first step to ditching the depth=0 on
npm update. The other thing we need to do before we do that is fix a bug where asking to update a named transitive dependency can cause an infinite loop inoutdated.