Skip to content
This repository has been archived by the owner. It is now read-only.

install/deps: Let git deps w/ lock only match package.json #20390

Closed
wants to merge 3 commits into from

Conversation

@iarna
Copy link
Contributor

@iarna iarna commented Apr 20, 2018

Previously they would only match if the complete commitid was used. This allows partial matching when no on-disk component is available.

This will need a minor patch to coordinate with #20384

@iarna iarna requested a review from as a code owner Apr 20, 2018
@zkat zkat changed the base branch from release-next to latest Apr 20, 2018
@zkat zkat changed the base branch from latest to release-next Apr 20, 2018
@zkat zkat force-pushed the 6-safe-git-deps branch from 9014156 to 042cd4c Apr 20, 2018
iarna added 2 commits Apr 20, 2018
Previously they would only match if the complete commitid was used.  This
allows partial matching when no on-disk component is available.

Fixes: #16839

PR-URL: #20390
Credit: @iarna
Reviewed-By: @zkat
@zkat zkat force-pushed the 6-safe-git-deps branch from 7583ef3 to 49c3435 Apr 20, 2018
@iarna iarna force-pushed the 6-safe-git-deps branch from b8777c8 to 7353d36 Apr 20, 2018
iarna added a commit that referenced this issue Apr 20, 2018
Previously they would only match if the complete commitid was used.  This
allows partial matching when no on-disk component is available.

Fixes: #16839

PR-URL: #20390
Credit: @iarna
Reviewed-By: @zkat
iarna added a commit that referenced this issue Apr 20, 2018
iarna added a commit that referenced this issue Apr 20, 2018
@iarna
Copy link
Contributor Author

@iarna iarna commented May 3, 2018

This landed starting at e4ed976 in 6.0.0

@iarna iarna closed this May 3, 2018
iarna added a commit that referenced this issue May 5, 2018
Previously they would only match if the complete commitid was used.  This
allows partial matching when no on-disk component is available.

Fixes: #16839

PR-URL: #20390
Credit: @iarna
Reviewed-By: @zkat
iarna added a commit that referenced this issue May 5, 2018
iarna added a commit that referenced this issue May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant