-
Notifications
You must be signed in to change notification settings - Fork 3k
Conversation
Looks like the commit log should be "Don't run restart if it doesn't exist", shouldn't it? I'm confused between your description and the code in the commit. |
No, the commit message makes sense. LGTM, @isaacs? |
LGTM |
Why isn't this merged? |
I think we can probably merge this if someone wants to update the docs for it as well. If not, I can tomorrow or sometime this week. |
The docs says: I think this should just be merged already:) |
This needs a test before it can be merged. |
This has been waiting for a test without getting one for over a year. Closing as abandoned. Thanks for taking the time to put it together, @scien, and sorry we let it languish for so long without providing feedback. If you want to take another stab at this, a new version, with tests, would be welcome. |
isaacs/npm#1999
npm restart currently runs prestop, stop, poststop, restart, prestart, start, poststart. According to the docs, and the original intention of the feature, a restart script should be able to be provided so the application can choose to restart their service gracefully (see isaacs/npm#184) instead of issueing a full stop/start.
A full stop/start should only happen if a restart script is not provided.