Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

fix broken tests #3909

Merged
merged 1 commit into from
Sep 20, 2013
Merged

Conversation

robertkowalski
Copy link
Contributor

GitHub changed the url scheme for gists, this is fixing the
failing tests

Please run npm test as I experience a another error probably from 2389525 which may be just related to my local machine

Fixes #3897

GitHub changed the url scheme for gists, this is fixing the
failing tests

Fixes npm#3897
@robertkowalski
Copy link
Contributor Author

My error is this, it disappears if I revert 2389525

+npm install /Users/robert/npm
 1> > npm@1.3.11 prepublish /Users/robert/npm
 1> > node bin/npm-cli.js prune ; rm -rf test/*/*/node_modules ; make -j4 doc
 1>
 1> make: Nothing to be done for `doc'.
 1> /var/folders/mm/8hsp08pd3133564vw7n1yvf80000gn/T/npm-test-67556/root/bin/npm -> /var/folders/mm/8hsp08pd3133564vw7n1yvf80000gn/T/npm-test-67556/root/lib/node_modules/npm/bin/npm-cli.js
 1> npm@1.3.11 /var/folders/mm/8hsp08pd3133564vw7n1yvf80000gn/T/npm-test-67556/root/lib/node_modules/npm
 2> npm ERR! Error: ENOENT, open '/var/folders/mm/8hsp08pd3133564vw7n1yvf80000gn/T/npm-test-67556/root/lib/package.json'
 2> npm ERR! If you need help, you may report this log at:
 2> npm ERR!     <http://github.com/isaacs/npm/issues>
 2> npm ERR! or email it to:
 2> npm ERR!     <npm-@googlegroups.com>
 2>
 2> npm ERR! System Darwin 12.4.0
 2> npm ERR! command "node" "/Users/robert/npm/bin/npm-cli.js" "prune"
 2> npm ERR! cwd /Users/robert/npm
 2> npm ERR! node -v v0.10.18
 2> npm ERR! npm -v 1.3.11
 2> npm ERR! path /var/folders/mm/8hsp08pd3133564vw7n1yvf80000gn/T/npm-test-67556/root/lib/package.json
 2> npm ERR! code ENOENT
 2> npm ERR! errno 34
 2> npm ERR!
 2> npm ERR! Additional logging details can be found in:
 2> npm ERR!     /Users/robert/npm/npm-debug.log
 2> npm ERR! not ok code 0
 2> npm WARN package.json github-url-from-git@1.1.1 No repository field.
 2>

@davglass
Copy link
Contributor

Can we get this merged in, some people need to make sure that make test works before we can pull changes :)

@luk- luk- merged commit 4fdeabb into npm:master Sep 20, 2013
@luk-
Copy link
Contributor

luk- commented Sep 20, 2013

landed on isaacs/npm@4fdeabb

@robertkowalski
Copy link
Contributor Author

👍 thanks!

@robertkowalski robertkowalski deleted the fix/broken-tests-github-update branch September 22, 2013 21:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants