This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
use writeFileAtomic instead of fs.writeFile fixes #6163 #6182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var done = inflight(pj, cb) | ||
|
|
||
| if (!done) return undefined | ||
|
|
||
| fs.writeFile(tmp, JSON.stringify(data), "utf8", function (er) { | ||
| getStat(function (er, cs) { |
There was a problem hiding this comment.
This getStat is unnecessary - writeFileAtomic will take care of this for you.
|
Adopt that change, and this looks good to go! Thank you! |
2 tasks
|
Alright, changed that and rebased from master. |
|
Landed in 17c941a. Thanks so much for contributing this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to strictly follow the tasks in #6163.
This is my first attempt to contribute to npm so I might completely messed up.
At least the tests are still passing for me after my commit.