Better pipe cleanup for early shrinkwrap reading #8718

iarna · 2015-06-27T05:09:01Z

zkat · 2015-06-29T22:25:31Z

lib/fetch-package-metadata.js

    stream = untar
    addClose()
  }

  function addClose () {
    stream.close = function () {
-      tounpipe.forEach(dispose)
+      tounpipe.forEach(function (streams) {
+        unpipe(streams[0],streams[1])


afaict, unpipe only takes one argument, and it unpipes all piped streams. See https://www.npmjs.com/package/unpipe (and source: https://github.com/stream-utils/unpipe/blob/master/index.js#L40)

You are correct! Good catch.

This reverts commit bc46ca9.

for 0.8 compatibility instead of trying to kill the streams by hand

for 0.8 compatibility instead of trying to kill the streams by hand Fixes #8695 PR-URL: #8718

iarna · 2015-07-01T13:35:57Z

Landed as 57c3cea

iarna added the bug label Jun 27, 2015

iarna added this to the 3.0.1 milestone Jun 27, 2015

iarna added the in-progress label Jun 27, 2015

zkat reviewed Jun 29, 2015
View reviewed changes

Revert "install: Make shrinkwrap extraction work in 0.8"

2de1c26

This reverts commit bc46ca9.

iarna force-pushed the iarna/fix-packaged-shrinkwrap branch from f864d04 to 60ecd29 Compare July 1, 2015 08:59

iarna added 2 commits July 1, 2015 05:00

unpipe@1.0.0

de8f892

fetch-package-metadata: use unpipe

afee6ff

for 0.8 compatibility instead of trying to kill the streams by hand

iarna force-pushed the iarna/fix-packaged-shrinkwrap branch from 60ecd29 to afee6ff Compare July 1, 2015 09:00

iarna added a commit that referenced this pull request Jul 1, 2015

fetch-package-metadata: use unpipe

57c3cea

for 0.8 compatibility instead of trying to kill the streams by hand Fixes #8695 PR-URL: #8718

iarna closed this Jul 1, 2015

iarna removed the in-progress label Jul 1, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better pipe cleanup for early shrinkwrap reading #8718

Better pipe cleanup for early shrinkwrap reading #8718

iarna commented Jun 27, 2015

zkat Jun 29, 2015

iarna Jun 29, 2015

iarna commented Jul 1, 2015

Better pipe cleanup for early shrinkwrap reading #8718

Better pipe cleanup for early shrinkwrap reading #8718

Conversation

iarna commented Jun 27, 2015

zkat Jun 29, 2015

Choose a reason for hiding this comment

iarna Jun 29, 2015

Choose a reason for hiding this comment

iarna commented Jul 1, 2015