This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Fix package.json handling to always allow BOM at start #8724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Remove byte order marker. This catches EF BB BF (the UTF-8 BOM) | ||
| // because the buffer-to-string conversion in `fs.readFileSync()` | ||
| // translates it to FEFF, the UTF-16 BOM. | ||
| if (content.charCodeAt(0) === 0xFEFF) { |
There was a problem hiding this comment.
This may have a bit of an awkward effect where states involving non-strong content will now throw the "wrong" error ("undefined is not a function"). Are we okay with that? I can see a couple of places in this PR where this seems to be possible.
iarna
force-pushed
the
iarna/allow-bom
branch
4 times, most recently
from
4b7d277
to
ddde606
Compare
|
@zkat: So it turns out that And more importantly, it won't explode w/ buffers. |
iarna
added a commit
that referenced
this pull request
Jul 1, 2015
|
This landed in master as 28064e5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3358