This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Fix the progress-config test when run from travis or other CI #9304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not fixed all the way yet ;.; https://travis-ci.org/npm/npm/jobs/75915883#L3826-L3859 |
iarna
force-pushed
the
iarna/fix-progress-config-on-travis
branch
from
4140a6f
to
4a02ed6
Compare
iarna
force-pushed
the
iarna/fix-progress-config-on-travis
branch
from
4a02ed6
to
46d6dee
Compare
|
Fixed! |
|
Reviewed by me via ScreenHero. 🐑 |
We have special code to disable the progress bar on travis (and other CI) to save ourselves and our users a lot of unhelpful output. Unfortunately as this test didn't take that into account, it immediately exploded in this envs. So we fix that up, PLUS we add tests for the various env options for suppressing progress bars.
iarna
force-pushed
the
iarna/fix-progress-config-on-travis
branch
from
46d6dee
to
4c1cebf
Compare
iarna
added a commit
that referenced
this pull request
Aug 21, 2015
We have special code to disable the progress bar on travis (and other CI) to save ourselves and our users a lot of unhelpful output. Unfortunately as this test didn't take that into account, it immediately exploded in this envs. So we fix that up, PLUS we add tests for the various env options for suppressing progress bars. PR-URL: #9304
|
Landed as ad3714c. Woop! Thanks, Rebecca! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have special code to disable the progress bar on travis (and other CI) to
save ourselves and our users a lot of unhelpful output. Unfortunately as
this test didn't take that into account, it immediately exploded in this
envs.
So we fix that up, PLUS we add tests for the various env options for
suppressing progress bars.