This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Fix removing of cmd-shims when removing modules #9537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iarna
force-pushed
the
iarna/fix-cmd-shim-windows
branch
from
7c1d9ee
to
88983cc
Compare
iarna
force-pushed
the
iarna/fix-cmd-shim-windows
branch
from
88983cc
to
98adf45
Compare
|
🐑from @othiym23 during screenhero code review yesterday |
|
🐑 🐑 🐑 |
|
This was shipped with 3.3.3! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing modules on windows, there was a bug that would result it in refusing remove any of the associated command shims.
This fixes: #9394
The root cause was the change made in #9198, which understood how to read symlinked bins but not how to read command shims.