sometimes the bin mapping is empty

npm · Feb 10, 2015 · 709976e · 709976e
1 parent 81fd5f7
commit 709976e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/read-json.js b/read-json.js
@@ -341,6 +341,7 @@ function checkBinReferences_ (file, data, warn, cb) {
 
                 var keys = Object.keys(data.bin)
                 var keysLeft = keys.length
+                if (!keysLeft) return cb()
 
                 function handleExists(relName, result) {
                                 keysLeft--

diff --git a/test/bin.js b/test/bin.js
@@ -12,7 +12,6 @@ var createWarningCollector = function () {
         return warn
 }
 
-console.error("Bin test")
 tap.test("Bin test", function (t) {
                 var p = path.resolve(__dirname, "fixtures/bin.json")
                 var warn = createWarningCollector()
@@ -32,3 +31,13 @@ tap.test("Bad bin test", function (t) {
                                 t.end()
                 })
 })
+
+tap.test("Empty bin test", function (t) {
+                var p = path.resolve(__dirname, "fixtures/emptybin.json")
+                var warn = createWarningCollector()
+                readJson(p, warn, function (er, data) {
+                                t.equals(warn.warnings.length, 0)
+                                t.same(data.bin, {}, "no mapping to bin because object was empty")
+                                t.end()
+                })
+})