chore: add new tests to reach full test coverage #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and remove a duplicate test)
wraithgar
reviewed
Feb 10, 2023
| t.same(validate(42), { | ||
| validForNewPackages: false, | ||
| validForOldPackages: false, | ||
| errors: ['name must be a string'] }) | ||
|
|
||
| t.same(validate(''), { |
There was a problem hiding this comment.
This is the duplicate for the test that was removed, for those following along.
wraithgar
changed the title
|
Thank you! |
Closed
Merged
lukekarrys
pushed a commit
that referenced
this pull request
May 6, 2024
🤖 I have created a release *beep* *boop* --- ## [5.0.1](v5.0.0...v5.0.1) (2024-05-06) ### Dependencies * [`f12f849`](f12f849) [#104](#104) replace `builtins` dependency with Node.js `module.builtinModules` (#104) ### Chores * [`f2b3233`](f2b3233) [#112](#112) auto publish (#112) (@lukekarrys) * [`406b31a`](406b31a) [#110](#110) bump @npmcli/template-oss to 4.22.0 (@lukekarrys) * [`bcc451a`](bcc451a) [#69](#69) update tap coverage in package.json (#69) (@wraithgar) * [`320e5dd`](320e5dd) [#68](#68) add new tests to reach full test coverage (#68) (@janbritz) * [`5c72411`](5c72411) [#59](#59) bump @npmcli/eslint-config from 3.1.0 to 4.0.0 (@dependabot[bot]) * [`a893e39`](a893e39) [#110](#110) postinstall for dependabot template-oss PR (@lukekarrys) * [`13f9b85`](13f9b85) [#109](#109) bump @npmcli/template-oss from 4.21.3 to 4.21.4 (@dependabot[bot]) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a duplicate test and adds three tests to reach full code coverage.
The three test cases cover the following invalid inputs:
nullundefined