Skip to content
This repository has been archived by the owner on Mar 26, 2021. It is now read-only.

Should the default API pull URL use production? #7

Closed
JeremyDunn opened this issue Nov 20, 2014 · 4 comments
Closed

Should the default API pull URL use production? #7

JeremyDunn opened this issue Nov 20, 2014 · 4 comments

Comments

@JeremyDunn
Copy link
Contributor

Is there a particular reason the default pull URL isn't using production (api.npr.org)?

https://github.com/npr/WP-DS-NPR-API/blob/master/ds-npr-api.php#L96

@JeremyDunn JeremyDunn changed the title Should the default API URL use production? Should the default API pull URL use production? Nov 20, 2014
@CrookedNumber
Copy link
Contributor

There probably isn't one. My best guess is that it's just force of habit, the desire to initially steer people to dev servers. That, and the fact that s2 is definitely the sensible default for push (though probably not for pull).

I'm happy turn this into an actionable ticket, if you'd like.

@JeremyDunn
Copy link
Contributor Author

I think it makes sense for the default pull URL to use production. Otherwise, if you want to immediately start pulling stories from the API (and don't think twice about accepting a default) you won't be receiving up-to-date content.

That or don't set a default at all and force the user to input it manually, which is currently how the push url is configured.

@CrookedNumber
Copy link
Contributor

Thanks! Done.

d195410

@JeremyDunn
Copy link
Contributor Author

thank you

aschweigert added a commit that referenced this issue Jun 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants