Fixed php warning bugs that show when debugging is turned on #16
Conversation
split() is deprecated. Check if variables are objects. Functions follow strict standards.
Static class name provided inside an object, instead of reference to object.
Make sure object is an object before checking if it is empty, same with arrays. Also added into get_stories a change that should have gone with last commit.
Object and variable checking conditionals
Adds the ability to add tags to stories imported with the NPR API Get Multi tool.
automatically tag with "NPR", clarified description for ds_npr_num
fixing a bug with previous commit to ensure that imported posts are always tagged with NPR
always tag with NPR
|
Hi @jglynnkcpt! This is awesome, thank you so much for submitting this! I'd like to merge it but there are a number of conflicts -- when you get a chance, could you rebase your branch off of the most recent release (there were a number of name changes and structural changes since then) and resubmit? I'd love to get this included in the next release! |
|
Sure thing! On Fri, Jul 22, 2016 at 8:47 AM, Mike Douglas notifications@github.com
Jirrod Glynn UX/UI Web Developer KCPT | The Bridge | Flatland 125 E. 31st St. Kansas City, MO 64108 816.398.4231 (o) 816.225.4218 (c) kcpt.org | bridge909.org | flatlandkc.org Kansas City Public Television | 125 East 31st Street, Kansas City, MO 64108 Connect with KCPT: FB: /kcpt19 | Twitter: @kcpt | Youtube: KCPTOnline |
All commits up to this point were specifically to fix PHP bugs that showed up on NPR screens when interacting with the plugin or even deleting existing posts.